[issue25] smart doesnt seach inside folders (sub-folders)

[Gustavo Niemeyer at Labix Tracker]

Gustavo Niemeyer <gustavo at niemeyer.net> added the comment:

Mauricio, thanks for the patch. It looks very nice. I have
only two remarks:

1) In debdir.py and rpmdir.py you're using the "recursive" string as
   a bool. Replace them by True.

2) In the deb_dir.py and rpm_dir.py channel implementations, you're
   doing "if self._recursive". While that certainly looks ok, there's a
   small trick here: these objects may be cached, which means that the
   new code may load up an object from a cache created by a previous
   version, and in that case the _recursive attribute doesn't yet
   exist. With that in mind, the right way to do it is using:

      if getattr(self, "_recursive", False):

   make sure you include a comment explaining it.

After fixing these issues, please apply the patch in the trunk.

Thanks again.

----------
nosy: +niemeyer
status: testing -> accepted

_______________________________________
Labix issue tracker <tracker at labix.org>
<http://tracker.labix.org/issue25>
_______________________________________