[PATCH] Fix obscure stack trace

Darrin Thompson darrint at progeny.com
Mon Apr 17 08:32:26 PDT 2006


Gustavo,

We were able, through some evil stupid hacking to send smart down a code
path where it tried to release the same lock twice. This silences the
trace. I don't know if it is a "fix". ;-)

--
Darrin

diff -urN /usr/lib/python2.3/site-packages/smart/backends/rpm/pm.py
smart/backends/rpm/pm.py
--- /usr/lib/python2.3/site-packages/smart/backends/rpm/pm.py	2005-08-10
17:34:22.000000000 -0400
+++ smart/backends/rpm/pm.py	2006-04-14 13:55:27.000000000 -0400
@@ -243,7 +243,8 @@
                     self.rpmout.close()
                     self.rpmout = None
         finally:
-            self.rpmoutlock.release()
+            if self.rpmoutlock.locked():
+                self.rpmoutlock.release()
 
     def _rpmoutthread(self):
         try:





More information about the Smart mailing list