some patches for yast2 channels

[Pascal Bleser]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Christoph Thiel wrote:
> On Sun, 8 Oct 2006, Pascal Bleser wrote:
>> Mauricio Teixeira (netmask) wrote:
>>> Em Sex, 2006-10-06 às 00:30 +0200, Christoph Thiel escreveu:
>>>>>   smart-yast-media.patch by Ludwig Nussel <lnussel at suse.de>
>>>>>   - implements multi media support for yast2 channels
>>> Very nice. Thanks!
>>> The most important question: have you tested this patch marking the
>>> channel as 'removable'? What happens? I don't have the complete CD set
>>> with me, so I can't test it right now.
>>
>> The patch is broken, don't include it.
>> After getting numerous complaints, I've dropped it again from my smart
>> build.
>>
>> Problem is: it modifies download URLs like e.g.
>> http://packman.inode.at/suse/10.0 into http://packman.inode.at/suse/10.1
> 
> No, it doesn't -- you haven't used the latests patch. That one will just 
> do something, if the latests digit is 1 and replace it with the media no 
> that the package is on (due to package metadata). So it won't even break 
> http://packman.inode.at/suse/10.1!

Right, the previous patch did the following:
  if u[len(u)-1:].isdigit():
and now it does
  if u[len(u)-1:] == '1':

Wouldn't it be better to only do that funky stuff when the channel is
marked as removable ?

u = self._loader._baseurl.rstrip("/");
if u[len(u)-1:] == '1':
   u = u.rstrip("1234567890")
   u += self._info.get("media")

Why not
   u = u.rstrip("1")
?

Hm, well.. still... so basically, it works when it's /10.1 at the end
because media is always set to "1" on internet repositories so you're
just r-stripping "1" and then appending "1" ?

- --
  -o) Pascal Bleser     http://linux01.gwdg.de/~pbleser/
  /\\ <pascal.bleser at skynet.be>       <guru at unixtech.be>
 _\_v The more things change, the more they stay insane.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)

iD8DBQFFKW3vr3NMWliFcXcRAmihAJ9DioVNPPEEGia/P6G1q2aOEIfrRACfVrpH
9FyHfmM4+/oNi3tbIUOCxs4=
=zD0g
-----END PGP SIGNATURE-----