[issue232] gtk/process.py cleanup

[Gustavo Niemeyer at Labix Tracker]

Gustavo Niemeyer <gustavo at niemeyer.net> added the comment:

Hello David,

> I am interested in working on the various interfaces [Text|gt|qt] for
> smartpm.  Seems like a good way to get my feet wet without getting into
> the dependency solver and backend stuff.
> 
> In order to start adding features and fixing bugs, I would like to
> enhance the readability of the existing codebase.

Yes, that's a nice idea, and please feel welcome to hack on Smart. We'll
be glad to integrate sensible patches you produce.

> A very simple readability fix would be to replace self.progress with
> self.progressbar in /gtk/progress.  According to HACKING, private
> variables should be _progress. Calling the gtk.ProgressBar self.progress
> rather than progressbar or _progress is confusing.

I don't understand your position here.  The mentioned code is already
using _progress.

----------
nosy: +niemeyer

_______________________________________
Labix issue tracker <tracker at labix.org>
<http://tracker.labix.org/issue232>
_______________________________________