[patch] add extra http headers to request

Mauricio Teixeira mteixeira at webset.net
Thu Nov 22 10:13:17 PST 2007


On Thu, 2007-11-22 at 15:36 -0200, Gustavo Niemeyer wrote:

>     fetcher.enqueue(url, http_headers={...})

You've got a point. I'm going to think about it.

> We have two different fetchers, one using PyCurl, and the other using
> urllib2.  It'd be important to add support for both of them, otherwise your
> plugin will break depending on installed dependencies.

Thanks for the reminder.

> Please provide full test coverage for the changes.

Will do.

Thanks for the review. :)

-- 
% Mauricio Teixeira (netmask) | Sao Paulo/SP/BR      %
% mteixeira{a}webset{d}net    | http://smartpm.org   %
% http://mteixeira.webset.net | http://pmping.sf.net %

NOTE: This is my personal e-mail account. I do NOT use
it to speak for my employer or any of my co-workers.




More information about the Smart mailing list