[issue355] smart upgrade crashes on serial or xen terminal

[Peter Warasin at Labix Tracker]

Peter Warasin <peter at endian.com> added the comment:

yes, that patch fixes the problem also. Did not see it before.
However, viewing the patch i think, the patch of issue172 is more a workaround
only for this specific problem.

But the problem is more that getScreenWidth sometimes can return 0 and that size
will be used also in other parts of the tool, which will also fail if fixed only
in text/progress.py like in patch of issue172

I think it would be better to fix it in getScreenWidth(). I am unsure if simply
returning 80 if the size is 0 is sufficient. Better would be to read it out
somewhere, but did not find any possibility for serial terminal emulation.
Also maybe returning 80 if the width is <20, like you mentioned would be better,
than simply returning 80 if it is 0, since the problem persists if the width
would be 4 for example.

_______________________________________
Labix issue tracker <tracker at labix.org>
<http://tracker.labix.org/issue355>
_______________________________________